Skip to content

Add virtual-scroll useKeyboard option support #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add virtual-scroll useKeyboard option support #106

wants to merge 3 commits into from

Conversation

weotch
Copy link

@weotch weotch commented Jun 10, 2019

This adds support for the useKeyboard option: https://github.com/ayamflow/virtual-scroll/blob/master/src/index.js#L37.

Also, it fixes issues where a user might set a boolean option to false explicitly but, instead, the default value would be use. Like right now, if preventTouch is false like:

new SmoothCustom({
  vs: { preventTouch: false }
})

... It will get re-set to true via:

this.options.vs.preventTouch || true

@yurayarosh yurayarosh mentioned this pull request Sep 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@weotch